linux-kernel - Re: [PATCH v4 2/3] drm/vc4: Don't try to initialize FBDEV if we're only bound to V3D.

Open Source and information security mailing list archives

Message-ID: <20170502092400.35owmdw2fgf4uquu@phenom.ffwll.local>
Date:   Tue, 2 May 2017 11:24:00 +0200
From:   Daniel Vetter <daniel@...ll.ch>
To:     Eric Anholt <eric@...olt.net>
Cc:     dri-devel@...ts.freedesktop.org, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/3] drm/vc4: Don't try to initialize FBDEV if we're
 only bound to V3D.

On Fri, Apr 28, 2017 at 03:42:22PM -0700, Eric Anholt wrote:
> The FBDEV initialization would throw an error in dmesg, when we just
> want to silently not initialize fbdev on a V3D-only VC4 instance.
> 
> Signed-off-by: Eric Anholt <eric@...olt.net>

With the commit message updated that passing num_connector is the bug that
throws the error (and not that we set up a no-op fbdev):

Reviewed-by: Daniel Vetter <daniel.vetter@...ll.ch>

Still kinda hoping for a follow-up to entirely get rid fo num_connector in
the fbdev init funcs.
-Daniel
> ---
>  drivers/gpu/drm/vc4/vc4_kms.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_kms.c b/drivers/gpu/drm/vc4/vc4_kms.c
> index ad7925a9e0ea..237a504f11f0 100644
> --- a/drivers/gpu/drm/vc4/vc4_kms.c
> +++ b/drivers/gpu/drm/vc4/vc4_kms.c
> @@ -230,10 +230,12 @@ int vc4_kms_load(struct drm_device *dev)
>  
>  	drm_mode_config_reset(dev);
>  
> -	vc4->fbdev = drm_fbdev_cma_init(dev, 32,
> -					dev->mode_config.num_connector);
> -	if (IS_ERR(vc4->fbdev))
> -		vc4->fbdev = NULL;
> +	if (dev->mode_config.num_connector) {
> +		vc4->fbdev = drm_fbdev_cma_init(dev, 32,
> +						dev->mode_config.num_connector);
> +		if (IS_ERR(vc4->fbdev))
> +			vc4->fbdev = NULL;
> +	}
>  
>  	drm_kms_helper_poll_init(dev);
>  
> -- 
> 2.11.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives