linux-kernel - Re: [PATCH v4] fpga manager: Add Altera CvP driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1493768214.22125.8.camel@perches.com>
Date:   Tue, 02 May 2017 16:36:54 -0700
From:   Joe Perches <joe@...ches.com>
To:     Anatolij Gustschin <agust@...x.de>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     linux-fpga@...r.kernel.org,
        Alan Tull <atull@...nsource.altera.com>,
        Moritz Fischer <moritz.fischer@...us.com>,
        matthew.gerlach@...ux.intel.com, yi1.li@...ux.intel.com,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] fpga manager: Add Altera CvP driver

On Tue, 2017-05-02 at 11:53 +0200, Anatolij Gustschin wrote:
> On Mon, 1 May 2017 23:06:16 +0300 Andy Shevchenko andy.shevchenko@...il.com wrote:
> > > +#define VSEC_CVP_MODE_CTRL_NUMCLKS     (0xff<<8) /* CVP_NUMCLKS */  
> > 
> > Is 0xff a mask here? (Btw, you missed spaces around <<)
> 
> yes, it is. Will add spaces (checkpatch didn't warn here).

It would with command line option --strict, otherwise not.