linux-kernel - Re: [PATCH -next] soc/qbman: fix implicit header dependency now causing build fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 3 May 2017 09:38:01 +1000
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Joerg Roedel <jroedel@...e.de>
Cc:     Paul Gortmaker <paul.gortmaker@...driver.com>,
        <linux-kernel@...r.kernel.org>, <linux-next@...r.kernel.org>,
        Scott Wood <oss@...error.net>, <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [PATCH -next] soc/qbman: fix implicit header dependency now
 causing build fails

Hi all,

On Tue, 2 May 2017 18:21:12 -0400 Paul Gortmaker <paul.gortmaker@...driver.com> wrote:
>
> In commit 461a6946b1f9 ("iommu: Remove pci.h include from
> trace/events/iommu.h") that header shuffle uncovered an implicit
> include in this driver, manifesting as:
> 
>     CC      drivers/soc/fsl/qbman/qman_portal.o
>     drivers/soc/fsl/qbman/qman_portal.c: In function 'qman_portal_probe':
>     drivers/soc/fsl/qbman/qman_portal.c:299:2: error: implicit declaration of function 'dma_set_mask'
>     drivers/soc/fsl/qbman/qman_portal.c:299:2: error: implicit declaration of function 'DMA_BIT_MASK'
>         if (dma_set_mask(dev, DMA_BIT_MASK(40))) {
>         ^
> 
> on the corenet32_smp_defconfig (and 64 bit respectively.)  The above
> commit was singled out via git bisect.
> 
> The header it was implictly relying on getting was dma-mapping.h - so
> we explicitly add it here.
> 
> Fixes: 461a6946b1f9 ("iommu: Remove pci.h include from trace/events/iommu.h")
> Cc: Joerg Roedel <jroedel@...e.de>
> Cc: Scott Wood <oss@...error.net>
> Cc: linuxppc-dev@...ts.ozlabs.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> ---
>  drivers/soc/fsl/qbman/qman_portal.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/soc/fsl/qbman/qman_portal.c b/drivers/soc/fsl/qbman/qman_portal.c
> index adbaa30d3c5a..4a6a8ae5e0aa 100644
> --- a/drivers/soc/fsl/qbman/qman_portal.c
> +++ b/drivers/soc/fsl/qbman/qman_portal.c
> @@ -30,6 +30,8 @@
>  
>  #include "qman_priv.h"
>  
> +#include <linux/dma-mapping.h>
> +
>  struct qman_portal *qman_dma_portal;
>  EXPORT_SYMBOL(qman_dma_portal);
>  
> -- 
> 2.11.0

Thanks, Paul, I was just getting around to looking into that build
failure.  I will add this to linux-next as a merge fix patch for the
merge of the iommu tree until Joerg gets around to including it in his
tree.

-- 
Cheers,
Stephen Rothwell