linux-kernel - Re: [PATCH] power: supply: twl4030-charger: make twl4030_bci_property_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <84E3CDD6-1B1D-4316-B23A-8F43B3C2E397@goldelico.com>
Date:   Wed, 3 May 2017 14:25:57 +0200
From:   "H. Nikolaus Schaller" <hns@...delico.com>
To:     Colin King <colin.king@...onical.com>,
        Sebastian Reichel <sre@...nel.org>
Cc:     Linux PM mailing list <linux-pm@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] power: supply: twl4030-charger: make twl4030_bci_property_is_writeable static

Hi Colin,

> Am 03.05.2017 um 12:33 schrieb Colin King <colin.king@...onical.com>:
> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> The function twl4030_bci_property_is_writeable can be made static
> as it does not need to be in global scope.

Indeed. Have tested and it still works.

> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
> drivers/power/supply/twl4030_charger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/twl4030_charger.c b/drivers/power/supply/twl4030_charger.c
> index abd10f6861ae..2f82d0e9ec1b 100644
> --- a/drivers/power/supply/twl4030_charger.c
> +++ b/drivers/power/supply/twl4030_charger.c
> @@ -943,7 +943,7 @@ static int twl4030_bci_set_property(struct power_supply *psy,
> 	return 0;
> }
> 
> -int twl4030_bci_property_is_writeable(struct power_supply *psy,
> +static int twl4030_bci_property_is_writeable(struct power_supply *psy,
> 				      enum power_supply_property psp)
> {
> 	switch (psp) {
> -- 
> 2.11.0
> 

Thanks and BR,
Nikolaus