linux-kernel - Re: [PATCH 2/2] can: m_can: add deep Suspend/Resume support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 3 May 2017 14:28:00 +0200
From:   Quentin Schulz <quentin.schulz@...e-electrons.com>
To:     Marc Kleine-Budde <mkl@...gutronix.de>, wg@...ndegger.com,
        mario.huettel@....net, socketcan@...tkopp.net
Cc:     linux-can@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, alexandre.belloni@...e-electrons.com,
        thomas.petazzoni@...e-electrons.com
Subject: Re: [PATCH 2/2] can: m_can: add deep Suspend/Resume support

Hi Marc,

On 03/05/2017 14:16, Marc Kleine-Budde wrote:
> On 05/03/2017 02:11 PM, Quentin Schulz wrote:
>> This adds Power Management deep Suspend/Resume support for Bosch M_CAN
>> chip.
>>
>> When the chip resumes from deep sleep, the RAM needs to be initialized
>> as it is done when the driver probes. The net interface also needs to be
>> closed and reopened to be fully functional.
> 
> Are you sure it's the closing and opening of the net interface. Maybe
> it's the m_can_start() and/or the subsequent m_can_chip_config()?
> 

You're right. The chip needs to be completely reinitialized (clocks,
chip itself) and it also closes and reopens the interface if I'm correct
with close_candev and open_candev.
I'm sending a v2 right away to fix the commit log.

Thanks,
Quentin
-- 
Quentin Schulz, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com



Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)