linux-kernel - Re: [PATCH v4] fpga manager: Add Altera CvP driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 3 May 2017 09:19:40 -0500
From:   Alan Tull <atull@...nel.org>
To:     Anatolij Gustschin <agust@...x.de>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        linux-fpga@...r.kernel.org,
        Alan Tull <atull@...nsource.altera.com>,
        Moritz Fischer <moritz.fischer@...us.com>,
        matthew.gerlach@...ux.intel.com, "Li, Yi" <yi1.li@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] fpga manager: Add Altera CvP driver

On Tue, May 2, 2017 at 7:14 PM, Anatolij Gustschin <agust@...x.de> wrote:
> On Wed, 3 May 2017 00:28:17 +0300
> Andy Shevchenko andy.shevchenko@...il.com wrote:
> ...
>>>>Is 0xff a mask here? (Btw, you missed spaces around <<)
>>>
>>> yes, it is. Will add spaces (checkpatch didn't warn here).
>>
>>Then it makes sense to add _MASK and use GENMASK() instead of direct value.
>
> ok, will do.
>
>>>>Why do we need that?!
>>>>In new drivers we try to avoid new module parameters. We have enough
>>>>interfaces nowadays to let driver know some details (quirks).
>>>
>>> Which interface is preffered here? Do you suggest sysfs? Won't be able
>>> to pass the parameter on kernel command line, then.
>>
>>Yes, my question here is to understand what so important that driver
>>needs module parameter.
>>Can you elaborate?
>
> the driver doesn't need this parameter, but it could help testing
> the loading of compressed or encrypted images.

Loading encrypted or compressed images can be keyed off of flags in
fpga_image_info.  Currently we have FPGA_MGR_ENCRYPTED_BITSTREAM  Will
need to add one for compressed such as FPGA_MGR_COMPRESSED_BITSTREAM

Alan