linux-kernel - RE: [PATCH] ASoC: da7218: Fix incorrect usage of bitwise '&' operator for SRM check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2E89032DDAA8B9408CB92943514A03370142AAE96A@SW-EX-MBX01.diasemi.com>
Date:   Wed, 3 May 2017 14:19:51 +0000
From:   Adam Thomson <Adam.Thomson.Opensource@...semi.com>
To:     Takashi Sakamoto <o-takashi@...amocchi.jp>,
        Adam Thomson <Adam.Thomson.Opensource@...semi.com>,
        Mark Brown <broonie@...nel.org>,
        "Liam Girdwood" <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        "Takashi Iwai" <tiwai@...e.com>
CC:     "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "Support Opensource" <Support.Opensource@...semi.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] ASoC: da7218: Fix incorrect usage of bitwise '&'
 operator for SRM check

On 03 May 2017 15:10, Takashi Sakamoto wrote:

> On May 3 2017 22:54, Adam Thomson wrote:
> > In the SRM lock check section of code the '&' bitwise operator is
> > used as part of checking lock status. Functionally the code works
> > as intended, but the conditional statement is a boolean comparison
> > so should really use '&&' logical operator instead. This commit
> > rectifies this discrepancy.
> >
> > Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@...semi.com>
> > ---
> >  sound/soc/codecs/da7218.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Reviewed-by: Takashi Sakamoto <o-takashi@...amocchi.jp>

Thanks :)

> > diff --git a/sound/soc/codecs/da7218.c b/sound/soc/codecs/da7218.c
> > index d256ebf..6e1940e 100644
> > --- a/sound/soc/codecs/da7218.c
> > +++ b/sound/soc/codecs/da7218.c
> > @@ -1457,7 +1457,7 @@ static int da7218_dai_event(struct
> snd_soc_dapm_widget *w,
> >  				++i;
> >  				msleep(DA7218_SRM_CHECK_DELAY);
> >  			}
> > -		} while ((i < DA7218_SRM_CHECK_TRIES) & (!success));
> > +		} while ((i < DA7218_SRM_CHECK_TRIES) && (!success));
> >
> >  		if (!success)
> >  			dev_warn(codec->dev, "SRM failed to lock\n");
> 
> Would you please fix codes for da7213, too?

Thought you may be re-spinning your patch, but that's fine. I'll send an update
for da7213 as well.