linux-kernel - Re: [PATCH] ASoC: da7218: Fix incorrect usage of bitwise '&' operator for SRM check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e03173b7-3ec5-7971-c996-7b9803cd0936@sakamocchi.jp>
Date:   Wed, 3 May 2017 23:10:21 +0900
From:   Takashi Sakamoto <o-takashi@...amocchi.jp>
To:     Adam Thomson <Adam.Thomson.Opensource@...semi.com>,
        Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Cc:     alsa-devel@...a-project.org,
        Support Opensource <support.opensource@...semi.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: da7218: Fix incorrect usage of bitwise '&' operator
 for SRM check

On May 3 2017 22:54, Adam Thomson wrote:
> In the SRM lock check section of code the '&' bitwise operator is
> used as part of checking lock status. Functionally the code works
> as intended, but the conditional statement is a boolean comparison
> so should really use '&&' logical operator instead. This commit
> rectifies this discrepancy.
> 
> Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@...semi.com>
> ---
>  sound/soc/codecs/da7218.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Takashi Sakamoto <o-takashi@...amocchi.jp>

> diff --git a/sound/soc/codecs/da7218.c b/sound/soc/codecs/da7218.c
> index d256ebf..6e1940e 100644
> --- a/sound/soc/codecs/da7218.c
> +++ b/sound/soc/codecs/da7218.c
> @@ -1457,7 +1457,7 @@ static int da7218_dai_event(struct snd_soc_dapm_widget *w,
>  				++i;
>  				msleep(DA7218_SRM_CHECK_DELAY);
>  			}
> -		} while ((i < DA7218_SRM_CHECK_TRIES) & (!success));
> +		} while ((i < DA7218_SRM_CHECK_TRIES) && (!success));
>  
>  		if (!success)
>  			dev_warn(codec->dev, "SRM failed to lock\n");

Would you please fix codes for da7213, too?


Regards

Takashi Sakamoto