linux-kernel - Re: [PATCH] driver: input :touchscreen : Change Raydium firmware update parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABXOdTeYyvTrB1R-zVx+zD=ArQqPtfwBHgk7tkZ_3UuzgVACxA@mail.gmail.com>
Date:   Wed, 3 May 2017 08:55:44 -0700
From:   Guenter Roeck <groeck@...gle.com>
To:     "jeffrey.lin" <yajohn@...il.com>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>, bleung@...omium.org,
        Guenter Roeck <groeck@...omium.org>,
        Katherine.Hsieh@...ntatw.com, Jeffrey Lin <jeffrey.lin@...-ic.com>,
        ealin.chiu@...-ic.com, calvin.tseng@...-ic.com, KP.li@...-ic.com,
        albert.shieh@...-ic.com,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-input@...r.kernel.org, devicetree@...r.kernel.org,
        "jeffrey.lin" <jeffrey.lin@...dium.corp-partner.google.com>
Subject: Re: [PATCH] driver: input :touchscreen : Change Raydium firmware
 update parameter

On Wed, May 3, 2017 at 8:37 AM, jeffrey.lin <yajohn@...il.com> wrote:
> From: "jeffrey.lin" <jeffrey.lin@...dium.corp-partner.google.com>
>
> Change boot mode trigger parameter of Raydium firmware update.
>

That is a bit vague. What is changed to what, and why ?

In other words, what prevents someone else from changing it back to
the old value, using the same description ?

> Signed-off-by: jeffrey.lin <jeffrey.lin@...-ic.com>
> ---
>  drivers/input/touchscreen/raydium_i2c_ts.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/touchscreen/raydium_i2c_ts.c b/drivers/input/touchscreen/raydium_i2c_ts.c
> index a99fb5cac5a0..8a81257634ba 100644
> --- a/drivers/input/touchscreen/raydium_i2c_ts.c
> +++ b/drivers/input/touchscreen/raydium_i2c_ts.c
> @@ -450,7 +450,7 @@ static bool raydium_i2c_boot_trigger(struct i2c_client *client)
>                 { 0x08, 0x04, 0x09, 0x00, 0x50, 0xA5 },
>                 { 0x08, 0x0C, 0x09, 0x00, 0x50, 0x00 },
>                 { 0x06, 0x01, 0x00, 0x00, 0x00, 0x00 },
> -               { 0x02, 0xA2, 0x00, 0x00, 0x00, 0x00 },
> +               { 0x02, 0xA1, 0x00, 0x00, 0x00, 0x00 },
>         };
>         int i;
>         int error;
> @@ -1199,7 +1199,7 @@ static SIMPLE_DEV_PM_OPS(raydium_i2c_pm_ops,
>                          raydium_i2c_suspend, raydium_i2c_resume);
>
>  static const struct i2c_device_id raydium_i2c_id[] = {
> -       { "raydium_i2c" , 0 },
> +       { "raydium_i2c", 0 },

Unrelated whitespace change.

>         { "rm32380", 0 },
>         { /* sentinel */ }
>  };
> --
> 2.12.2
>