linux-kernel - Re: [PATCH] driver: input :touchscreen : Change Raydium firmware update parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170504014306.417-1-jeffrey.lin@rad-ic.com>
Date:   Thu,  4 May 2017 09:43:06 +0800
From:   "jeffrey.lin" <yajohn@...il.com>
To:     dmitry.torokhov@...il.com, bleung@...omium.org,
        groeck@...omium.org, Katherine.Hsieh@...ntatw.com
Cc:     jeffrey.lin@...-ic.com, ealin.chiu@...-ic.com,
        calvin.tseng@...-ic.com, KP.li@...-ic.com, albert.shieh@...-ic.com,
        linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH] driver: input :touchscreen : Change Raydium firmware update parameter

Hi Guenter:
>> Change boot mode trigger parameter of Raydium firmware update.
>>

>That is a bit vague. What is changed to what, and why ?

>In other words, what prevents someone else from changing it back to
>the old value, using the same description ?

This bit control erase type as doing firmware update. We want just reserve more infomation after pass through production line. This's convenient
 for debug, so that it's okay as some one use old version.

>> Signed-off-by: jeffrey.lin <jeffrey.lin@...-ic.com>
>> ---
>>  drivers/input/touchscreen/raydium_i2c_ts.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/input/touchscreen/raydium_i2c_ts.c b/drivers/input/touchscreen/raydium_i2c_ts.c
>> index a99fb5cac5a0..8a81257634ba 100644
>> --- a/drivers/input/touchscreen/raydium_i2c_ts.c
>> +++ b/drivers/input/touchscreen/raydium_i2c_ts.c
>> @@ -450,7 +450,7 @@ static bool raydium_i2c_boot_trigger(struct i2c_client *client)
>>                 { 0x08, 0x04, 0x09, 0x00, 0x50, 0xA5 },
>>                 { 0x08, 0x0C, 0x09, 0x00, 0x50, 0x00 },
>>                 { 0x06, 0x01, 0x00, 0x00, 0x00, 0x00 },
>> -               { 0x02, 0xA2, 0x00, 0x00, 0x00, 0x00 },
>> +               { 0x02, 0xA1, 0x00, 0x00, 0x00, 0x00 },
>>         };


Thanks.

Jeffrey