linux-kernel - [PATCH] rt286: add Thinkpad Helix 2 to force_combo_jack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170503173414.GA28670@localhost.localdomain>
Date:   Thu, 4 May 2017 01:34:14 +0800
From:   Yifeng Li <tomli@...li.me>
To:     alsa-devel@...a-project.org
Cc:     bardliao@...ltek.com, oder_chiou@...ltek.com, broonie@...nel.org,
        yang.jie@...ux.intel.com, jinliangx.wang@...el.com,
        stable@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] rt286: add Thinkpad Helix 2 to force_combo_jack_table

Thinkpad Helix 2 is a tablet PC, the audio is powered by Core M
broadwell-audio and rt286 codec. For all versions of Linux kernel,
the stereo output doesn't work properly when earphones are plugged
in, the sound was coming out from both channels even if the audio
contains only the left or right channel. Furthermore, if a music
recorded in stereo is played, the two channels cancle out each other
out, as a result, no voice but only distorted background music can be
heard, like a sound card with builtin a Karaoke sount effect.

Apparently this tablet uses a combo jack with polarity incorrectly
set by rt286 driver. This patch adds DMI information of Thinkpad Helix 2
to force_combo_jack_table[] and the issue is resolved. The microphone
input doesn't work regardless to the presence of this patch and still
needs help from other developers to investigate.

This is my first patch to LKML directly, sorry for CC-ing too many
people here.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=93841
Cc: Bard Liao <bardliao@...ltek.com>
Cc: Oder Chiou <oder_chiou@...ltek.com>
Cc: Mark Brown <broonie@...nel.org>
Cc: Keyon <yang.jie@...ux.intel.com>
Cc: Jinliang Wang <jinliangx.wang@...el.com>
Cc: stable@...r.kernel.org
Signed-off-by: Yifeng Li <tomli@...li.me>
---
 sound/soc/codecs/rt286.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/sound/soc/codecs/rt286.c b/sound/soc/codecs/rt286.c
index 9c365a7f758d..7899a2cdeb42 100644
--- a/sound/soc/codecs/rt286.c
+++ b/sound/soc/codecs/rt286.c
@@ -1108,6 +1108,13 @@ static const struct dmi_system_id force_combo_jack_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "Kabylake Client platform")
 		}
 	},
+	{
+		.ident = "Thinkpad Helix 2nd",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad Helix 2nd")
+		}
+	},

 	{ }
 };
-- 
2.12.1