linux-kernel - Re: [PATCH v2 03/10] pinctrl: sunxi: add A20 support to A10 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 04 May 2017 22:45:11 +0800
From:   Icenowy Zheng <icenowy@...c.io>
To:     linux-arm-kernel@...ts.infradead.org,
        Maxime Ripard <maxime.ripard@...e-electrons.com>
CC:     devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-sunxi@...glegroups.com, linux-kernel@...r.kernel.org,
        linux-gpio@...r.kernel.org, Chen-Yu Tsai <wens@...e.org>,
        Rob Herring <robh+dt@...nel.org>, linux-clk@...r.kernel.org
Subject: Re: [PATCH v2 03/10] pinctrl: sunxi: add A20 support to A10 driver



于 2017年5月4日 GMT+08:00 下午10:41:52, Maxime Ripard <maxime.ripard@...e-electrons.com> 写到:
>On Thu, May 04, 2017 at 10:03:26PM +0800, Icenowy Zheng wrote:
>> 
>> 
>> 于 2017年5月4日 GMT+08:00 下午10:02:20, Maxime Ripard
><maxime.ripard@...e-electrons.com> 写到:
>> >On Thu, May 04, 2017 at 09:49:59PM +0800, Icenowy Zheng wrote:
>> >>  static const struct of_device_id sun4i_a10_pinctrl_match[] = {
>> >> -	{ .compatible = "allwinner,sun4i-a10-pinctrl", },
>> >> +	{
>> >> +		.compatible = "allwinner,sun4i-a10-pinctrl",
>> >> +		.data = (void *)PINCTRL_SUN4I_A10
>> >> +	},
>> >> +	{
>> >> +		.compatible = "allwinner,sun7i-a20-pinctrl",
>> >> +		.data = (void *)PINCTRL_SUN7I_A20
>> >> +	},
>> >>  	{}
>> >>  };
>> >
>> >This means you're going to have two drivers probing for the same
>> >device: this driver, and the old one. This is not ok, and probably
>> >introduces some corner cases.
>> 
>> The A20 driver is dropped in the next commit.
>
>Yes, and that is an issue for bisectability. Anyone that will checkout
>between those two commits will have a broken kernel, and that is not
>ok. Any commit should be in a working state.

Squash them together?

>
>Maxime