linux-kernel - [tip:core/urgent] stackprotector: Increase the per-task stack canary's random range from 32 bits to 64 bits on 64-bit platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 5 May 2017 01:10:40 -0700
From:   tip-bot for Daniel Micay <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     mingo@...nel.org, peterz@...radead.org, keescook@...omium.org,
        torvalds@...ux-foundation.org, tglx@...utronix.de,
        linux-kernel@...r.kernel.org, arjan@...ux.intel.com, hpa@...or.com,
        danielmicay@...il.com, riel@...hat.com
Subject: [tip:core/urgent] stackprotector: Increase the per-task stack
 canary's random range from 32 bits to 64 bits on 64-bit platforms

Commit-ID:  5ea30e4e58040cfd6434c2f33dc3ea76e2c15b05
Gitweb:     http://git.kernel.org/tip/5ea30e4e58040cfd6434c2f33dc3ea76e2c15b05
Author:     Daniel Micay <danielmicay@...il.com>
AuthorDate: Thu, 4 May 2017 09:32:09 -0400
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Fri, 5 May 2017 08:05:13 +0200

stackprotector: Increase the per-task stack canary's random range from 32 bits to 64 bits on 64-bit platforms

The stack canary is an 'unsigned long' and should be fully initialized to
random data rather than only 32 bits of random data.

Signed-off-by: Daniel Micay <danielmicay@...il.com>
Acked-by: Arjan van de Ven <arjan@...ux.intel.com>
Acked-by: Rik van Riel <riel@...hat.com>
Acked-by: Kees Cook <keescook@...omium.org>
Cc: Arjan van Ven <arjan@...ux.intel.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: kernel-hardening@...ts.openwall.com
Cc: stable@...r.kernel.org
Link: http://lkml.kernel.org/r/20170504133209.3053-1-danielmicay@gmail.com
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 kernel/fork.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/fork.c b/kernel/fork.c
index 3a4343c..d681f8f 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -536,7 +536,7 @@ static struct task_struct *dup_task_struct(struct task_struct *orig, int node)
 	set_task_stack_end_magic(tsk);
 
 #ifdef CONFIG_CC_STACKPROTECTOR
-	tsk->stack_canary = get_random_int();
+	tsk->stack_canary = get_random_long();
 #endif
 
 	/*