linux-kernel - Re: [tip:x86/urgent] x86/mm/kaslr: Use the _ASM_MUL macro for multiplication to work around Clang incompatibility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 5 May 2017 12:25:55 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     mka@...omium.org, md@...gle.com, tglx@...utronix.de, hpa@...or.com,
        torvalds@...ux-foundation.org, grundler@...omium.org,
        linux-kernel@...r.kernel.org, mingo@...nel.org,
        ghackmann@...gle.com, keescook@...omium.org
Cc:     linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/urgent] x86/mm/kaslr: Use the _ASM_MUL macro for
 multiplication to work around Clang incompatibility

On Fri, May 05, 2017 at 01:11:47AM -0700, tip-bot for Matthias Kaehlcke wrote:
> Commit-ID:  121843eb02a6e2fa30aefab64bfe183c97230c75
> Gitweb:     http://git.kernel.org/tip/121843eb02a6e2fa30aefab64bfe183c97230c75
> Author:     Matthias Kaehlcke <mka@...omium.org>
> AuthorDate: Mon, 1 May 2017 15:47:41 -0700
> Committer:  Ingo Molnar <mingo@...nel.org>
> CommitDate: Fri, 5 May 2017 08:31:05 +0200
> 
> x86/mm/kaslr: Use the _ASM_MUL macro for multiplication to work around Clang incompatibility
> 
> The constraint "rm" allows the compiler to put mix_const into memory.
> When the input operand is a memory location then MUL needs an operand
> size suffix, since Clang can't infer the multiplication width from the
> operand.

*sigh*, this is another shining example of how LLVM is a better, faster
moving compiler?