[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 5 May 2017 12:56:47 -0700
From: Greg KH <gregkh@...uxfoundation.org>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: thierry.escande@...labora.com, wnhuang@...gle.com,
linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] firmware: Google VPD: Fix memory allocation error
handling
On Fri, May 05, 2017 at 09:08:44PM +0200, Christophe JAILLET wrote:
> This patch fixes several issues:
> - if the 1st 'kzalloc' fails, we dereference a NULL pointer
> - if the 2nd 'kzalloc' fails, there is a memory leak
> - if 'sysfs_create_bin_file' fails there is also a memory leak
Then it should be multiple patches, not fixing 3 things in one patch,
right?
thanks,
greg k-h
Powered by blists - more mailing lists