linux-kernel - Re: [PATCH] firmware: Google VPD: Fix memory allocation error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <288831dc-38d6-21fd-118f-bcc0d44c0755@wanadoo.fr>
Date:   Sat, 6 May 2017 07:02:14 +0200
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     thierry.escande@...labora.com, wnhuang@...gle.com,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] firmware: Google VPD: Fix memory allocation error
 handling

Le 05/05/2017 à 21:56, Greg KH a écrit :
> On Fri, May 05, 2017 at 09:08:44PM +0200, Christophe JAILLET wrote:
>> This patch fixes several issues:
>>     - if the 1st 'kzalloc' fails, we dereference a NULL pointer
>>     - if the 2nd 'kzalloc' fails, there is a memory leak
>>     - if 'sysfs_create_bin_file' fails there is also a memory leak
> Then it should be multiple patches, not fixing 3 things in one patch,
> right?
>
> thanks,
>
> greg k-h
>
I can split it if you want, but the 3 points are more or less related 
and all belong to the same few lines of code. I didn't think having 3 
patches was needed in this case. I just wanted to give a detailed changelog.
If the commit message was only "This patch fixes memory allocation error 
handling in fct xxx' (as in the topic), I guess it would has been 
accepted (if it is correct of course) as-is.

Just tell me if you really prefer 3 patches, and I will resubmit.

CJ