linux-kernel - Re: [PATCH v3 1/2] thermal: core: Allow orderly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170507210219.GB25628@atrey.karlin.mff.cuni.cz>
Date:   Sun, 7 May 2017 23:02:19 +0200
From:   Pavel Machek <pavel@....cz>
To:     Keerthy <j-keerthy@...com>
Cc:     rui.zhang@...el.com, edubezval@...il.com, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
        nm@...com, t-kristo@...com
Subject: Re: [PATCH v3 1/2] thermal: core: Allow orderly_poweroff to be
 called only once

> thermal_zone_device_check --> thermal_zone_device_update -->
> handle_thermal_trip --> handle_critical_trips --> orderly_poweroff
> 
> The above sequence happens every 250/500 mS based on the configuration.
> The orderly_poweroff function is getting called every 250/500 mS.
> With a full fledged file system it takes at least 5-10 Seconds to
> power off gracefully.
> 
> In that period due to the thermal_zone_device_check triggering
> periodically the thermal work queues bombard with
> orderly_poweroff calls multiple times eventually leading to
> failures in gracefully powering off the system.
> 
> Make sure that orderly_poweroff is called only once.

Pretty please, can we do it in the core code, not in thermal/? There
are other reasons kernel may want to shut the system down, like for
example critical battery, and if both thermal _and_ bad battery
happen, we want just one shutdown...

> Reported-by: Keerthy <j-keerthy@...com>
> Signed-off-by: Keerthy <j-keerthy@...com>

And here probably we need your full name.

Thanks,
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html