linux-kernel - Re: [PATCH] platform/x86: toshiba_acpi: use memdup_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfhU1GWskBAqo4dMThHTQ4Fiz5owx2A8fJaRZWqMMZopA@mail.gmail.com>
Date:   Sun, 7 May 2017 14:42:50 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Geliang Tang <geliangtang@...il.com>
Cc:     Azael Avalos <coproscefalo@...il.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: toshiba_acpi: use memdup_user_nul

On Sat, May 6, 2017 at 6:40 PM, Geliang Tang <geliangtang@...il.com> wrote:
> Use memdup_user_nul() helper instead of open-coding to simplify the
> code.
>

Pushed to testing, thanks.

> Signed-off-by: Geliang Tang <geliangtang@...il.com>
> ---
>  drivers/platform/x86/toshiba_acpi.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c
> index d0daf75..88f9f79 100644
> --- a/drivers/platform/x86/toshiba_acpi.c
> +++ b/drivers/platform/x86/toshiba_acpi.c
> @@ -1502,14 +1502,9 @@ static ssize_t video_proc_write(struct file *file, const char __user *buf,
>         int ret;
>         u32 video_out;
>
> -       cmd = kmalloc(count + 1, GFP_KERNEL);
> -       if (!cmd)
> -               return -ENOMEM;
> -       if (copy_from_user(cmd, buf, count)) {
> -               kfree(cmd);
> -               return -EFAULT;
> -       }
> -       cmd[count] = '\0';
> +       cmd = memdup_user_nul(buf, count);
> +       if (IS_ERR(cmd))
> +               return PTR_ERR(cmd);
>
>         buffer = cmd;
>
> --
> 2.9.3
>



-- 
With Best Regards,
Andy Shevchenko