linux-kernel - Re: [PATCH] Staging: greybus: Prefer kcalloc over kzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 8 May 2017 11:35:42 +0100
From:   Rui Miguel Silva <rmfrfs@...il.com>
To:     karthik@...hveda.org
Cc:     johan@...nel.org, elder@...nel.org, gregkh@...uxfoundation.org,
        greybus-dev@...ts.linaro.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: greybus: Prefer kcalloc over kzalloc

Hi Karthik,
Thanks for the patch.

On Sat, May 06, 2017 at 07:44:10PM +0530, karthik@...hveda.org wrote:
>From: Karthik Tummala <karthik@...hveda.org>
>
>Fixed following checkpatch.pl warning:
> * WARNING: Prefer kcalloc over kzalloc with multiply
>
>Instead of specifying no.of bytes * size as arugment
>in kzalloc, prefer kcalloc.
>
>Signed-off-by: Karthik Tummala <karthik@...hveda.org>

Can you send a v2 with a subject similar to the other commits in
the file. i.e, starting with staging: greybus: light: ...

And you have a typo in the change log s/arugment/argument/.

If this two are fixed, you can add my:
Reviewed-by: Rui Miguel Silva <rmfrfs@...il.com>

Cheers,
   Rui
>---
> drivers/staging/greybus/light.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c
>index 1681362..861a249 100644
>--- a/drivers/staging/greybus/light.c
>+++ b/drivers/staging/greybus/light.c
>@@ -1030,7 +1030,7 @@ static int gb_lights_light_config(struct gb_lights *glights, u8 id)
> 	light->channels_count = conf.channel_count;
> 	light->name = kstrndup(conf.name, NAMES_MAX, GFP_KERNEL);
>
>-	light->channels = kzalloc(light->channels_count *
>+	light->channels = kcalloc(light->channels_count,
> 				  sizeof(struct gb_channel), GFP_KERNEL);
> 	if (!light->channels)
> 		return -ENOMEM;
>@@ -1167,7 +1167,7 @@ static int gb_lights_create_all(struct gb_lights *glights)
> 	if (ret < 0)
> 		goto out;
>
>-	glights->lights = kzalloc(glights->lights_count *
>+	glights->lights = kcalloc(glights->lights_count,
> 				  sizeof(struct gb_light), GFP_KERNEL);
> 	if (!glights->lights) {
> 		ret = -ENOMEM;
>-- 
>1.9.1
>