[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1494246955-14245-1-git-send-email-karthik@techveda.org>
Date: Mon, 8 May 2017 18:05:55 +0530
From: karthik@...hveda.org
To: rmfrfs@...il.com, johan@...nel.org, elder@...nel.org,
gregkh@...uxfoundation.org
Cc: greybus-dev@...ts.linaro.org, devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org, sunil.m@...hveda.org,
Karthik Tummala <karthik@...hveda.org>
Subject: [PATCH v2] Staging: greybus: light: Prefer kcalloc over kzalloc
From: Karthik Tummala <karthik@...hveda.org>
Fixed following checkpatch.pl warning:
* WARNING: Prefer kcalloc over kzalloc with multiply
Instead of specifying no.of bytes * size as argument
in kzalloc, prefer kcalloc.
Signed-off-by: Karthik Tummala <karthik@...hveda.org>
Reviewed-by: Rui Miguel Silva <rmfrfs@...il.com>
---
Changes for v2:
- Changed subject line & fixed typo as suggested by
Rui Miguel Silva
---
drivers/staging/greybus/light.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c
index 1681362..861a249 100644
--- a/drivers/staging/greybus/light.c
+++ b/drivers/staging/greybus/light.c
@@ -1030,7 +1030,7 @@ static int gb_lights_light_config(struct gb_lights *glights, u8 id)
light->channels_count = conf.channel_count;
light->name = kstrndup(conf.name, NAMES_MAX, GFP_KERNEL);
- light->channels = kzalloc(light->channels_count *
+ light->channels = kcalloc(light->channels_count,
sizeof(struct gb_channel), GFP_KERNEL);
if (!light->channels)
return -ENOMEM;
@@ -1167,7 +1167,7 @@ static int gb_lights_create_all(struct gb_lights *glights)
if (ret < 0)
goto out;
- glights->lights = kzalloc(glights->lights_count *
+ glights->lights = kcalloc(glights->lights_count,
sizeof(struct gb_light), GFP_KERNEL);
if (!glights->lights) {
ret = -ENOMEM;
--
1.9.1
Powered by blists - more mailing lists