linux-kernel - Re: [PATCH] mfd: cros-ec: Add cros_ec_readmem() helpers for I2C/SPI based ECs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170509163456.GA5885@tyrael.amer.corp.natinst.com>
Date:   Tue, 9 May 2017 09:34:56 -0700
From:   Moritz Fischer <mdf@...nel.org>
To:     kbuild test robot <lkp@...el.com>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org,
        linux@...ck-us.net, lee.jones@...aro.org, bleung@...omium.org,
        olof@...om.net
Subject: Re: [PATCH] mfd: cros-ec: Add cros_ec_readmem() helpers for I2C/SPI
 based ECs

On Tue, May 09, 2017 at 01:56:14PM +0800, kbuild test robot wrote:
> Hi Moritz,
> 
> [auto build test WARNING on ljones-mfd/for-mfd-next]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Moritz-Fischer/mfd-cros-ec-Add-cros_ec_readmem-helpers-for-I2C-SPI-based-ECs/20170509-040606
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
> config: tile-allmodconfig
> compiler: tilegx-linux-gcc (GCC) 4.6.2
> reproduce:
>         wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         make.cross ARCH=tile  allmodconfig
>         make.cross ARCH=tile 

I just locally ran that and it wouldn't print a warning. False positive?

> 
> All warnings (new ones prefixed by >>):
> 
> 
> vim +279 drivers/mfd/cros_ec.c
> 
>    263		return 0;
>    264	}
>    265	EXPORT_SYMBOL(cros_ec_resume);
>    266	
>    267	#endif
>    268	
>    269	int cros_ec_readmem(struct cros_ec_device *ec, unsigned int offset,
>    270				   unsigned int bytes, void *dest)
>    271	{
>    272		int ret;
>    273		struct ec_params_read_memmap *params;
>    274		struct cros_ec_command *msg;
>    275	
>    276		if (offset >= EC_MEMMAP_SIZE - bytes)
>    277			return -EINVAL;
>    278	
>  > 279		msg = kzalloc(sizeof(*msg) + max(sizeof(*params), bytes), GFP_KERNEL);

What am I not seeing here?
>    280		if (!msg)
>    281			return -ENOMEM;
>    282	
>    283		msg->version = 0;
>    284		msg->command = EC_CMD_READ_MEMMAP;
>    285		msg->insize = bytes;
>    286		msg->outsize = sizeof(*params);
>    287	
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Thanks,

Moritz

Download attachment "signature.asc" of type "application/pgp-signature" (456 bytes)