linux-kernel - Re: [PATCH v1 2/3] platform/x86: thinkpad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1494351185.30052.94.camel@linux.intel.com>
Date:   Tue, 09 May 2017 20:33:05 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Henrique de Moraes Holschuh <hmh@....eng.br>
Cc:     Henrique de Moraes Holschuh <ibm-acpi@....eng.br>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        ibm-acpi-devel@...ts.sourceforge.net,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 2/3] platform/x86: thinkpad_acpi: Join string
 literals back

On Tue, 2017-05-09 at 14:10 -0300, Henrique de Moraes Holschuh wrote:

Thanks for review, my comments below.

> On Tue, 09 May 2017, Andy Shevchenko wrote:
> > There is no point to keep string literal split. It even makes
> > slightly
> > harder to maintain and debug.
> 
> Ooold code, from a time when random people would annoy others over
> 80-column instead of doing useful reviews...

Yes, I know, nowadays checkpatch doesn't complain on them.

> > While here, print negative error without changing a sign as it is a
> > common pattern in the kernel.
> 
> A separate patch for this would be better: it would be easier to
> actually check that no functional changes crept in by mistake.

It doesn't make sense to me. It would touch same lines of code I do
already here and it's only one place, see below.

> >  	rc = fan_set_enable();
> >  	if (rc < 0) {
> > -		pr_err("fan watchdog: error %d while enabling fan,
> > "
> > -		       "will try again later...\n", -rc);
> > +		pr_err("fan watchdog: error %d while enabling fan,
> > will try again later...\n",
> > +		       rc);


-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy