lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 09 May 2017 11:23:19 -0700 From: Joe Perches <joe@...ches.com> To: Noralf Trønnes <noralf@...nnes.org>, SF Markus Elfring <elfring@...rs.sourceforge.net>, dri-devel@...ts.freedesktop.org, Daniel Vetter <daniel.vetter@...ll.ch>, David Airlie <airlied@...ux.ie>, Fengguang Wu <fengguang.wu@...el.com>, Thierry Reding <treding@...dia.com> Cc: kernel-janitors@...r.kernel.org, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] tinydrm: mipi-dbi: Use seq_putc() in mipi_dbi_debugfs_command_show() On Tue, 2017-05-09 at 19:29 +0200, Noralf Trønnes wrote: > Den 08.05.2017 13.54, skrev SF Markus Elfring: > > A single character (line break) should be put into a sequence. > > Thus use the corresponding function "seq_putc". Markus, I know this is hard for you, but think more before sending patches. > > diff --git a/drivers/gpu/drm/tinydrm/mipi-dbi.c b/drivers/gpu/drm/tinydrm/mipi-dbi.c [] > > @@ -946,7 +946,7 @@ static int mipi_dbi_debugfs_command_show(struct seq_file *m, void *unused) > > > > for (i = 0; i < len; i++) > > seq_printf(m, "%02x", val[i]); > > - seq_puts(m, "\n"); > > + seq_putc(m, '\n'); Use the %p<foo> extensions. seq_printf(m, "%*phN\n", len, val)
Powered by blists - more mailing lists