linux-kernel - Re: [PATCH] tinydrm: mipi-dbi: Use seq_putc() in mipi_dbi_debugfs_command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a6e57ed-7d71-78bc-706e-3a6a1eea3a23@tronnes.org>
Date:   Tue, 9 May 2017 19:29:39 +0200
From:   Noralf Trønnes <noralf@...nnes.org>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        dri-devel@...ts.freedesktop.org,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        David Airlie <airlied@...ux.ie>,
        Fengguang Wu <fengguang.wu@...el.com>,
        Thierry Reding <treding@...dia.com>
Cc:     kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tinydrm: mipi-dbi: Use seq_putc() in
 mipi_dbi_debugfs_command_show()


Den 08.05.2017 13.54, skrev SF Markus Elfring:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Mon, 8 May 2017 13:42:03 +0200
>
> A single character (line break) should be put into a sequence.
> Thus use the corresponding function "seq_putc".
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---

Thanks,

Acked-by: Noralf Trønnes <noralf@...nnes.org>

>   drivers/gpu/drm/tinydrm/mipi-dbi.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tinydrm/mipi-dbi.c b/drivers/gpu/drm/tinydrm/mipi-dbi.c
> index f4eb412f3604..54d66b732d55 100644
> --- a/drivers/gpu/drm/tinydrm/mipi-dbi.c
> +++ b/drivers/gpu/drm/tinydrm/mipi-dbi.c
> @@ -946,7 +946,7 @@ static int mipi_dbi_debugfs_command_show(struct seq_file *m, void *unused)
>   
>   		for (i = 0; i < len; i++)
>   			seq_printf(m, "%02x", val[i]);
> -		seq_puts(m, "\n");
> +		seq_putc(m, '\n');
>   	}
>   
>   	return 0;