linux-kernel - Re: [PATCH] irqchip/bcm2836: Move SMP startup code to arch/arm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55d1d773-7220-6448-5ef4-e9b5595c0f68@raspberrypi.org>
Date:   Wed, 10 May 2017 16:32:48 +0100
From:   Phil Elwell <phil@...pberrypi.org>
To:     Marc Zyngier <marc.zyngier@....com>, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Cc:     Eric Anholt <eric@...olt.net>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>
Subject: Re: [PATCH] irqchip/bcm2836: Move SMP startup code to arch/arm

On 10/05/2017 16:31, Marc Zyngier wrote:
> On 10/05/17 16:07, Phil Elwell wrote:
>> On 10/05/2017 14:32, Marc Zyngier wrote:
>>> On 10/05/17 14:26, Marc Zyngier wrote:
>>>> One of the RPi-2/3 irqchip's key features is that it contains some
>>>> SMP startup code for the 32bit ARM architecture version. The only
>>>> reason I can imagine for this is "RPi is special".
>>>>
>>>> Let's move this code where it belongs (in the platform support code),
>>>> creating a shared include file for this purpose.
>>>>
>>>> Signed-off-by: Marc Zyngier <marc.zyngier@....com>
>>>
>>> Also:
>>> Fixes: 41f4988cc287 ("irqchip/bcm2836: Add SMP support for the 2836")
>>>
>>> 	M.
>>>
>>
>> The patch has some checkpatch warnings, but otherwise:
> 
> Bah...
> 
> WARNING: line over 80 characters
> #51: FILE: arch/arm/mach-bcm/board_bcm2835.c:30:
> +static int bcm2836_smp_boot_secondary(unsigned int cpu, struct task_struct *idle)
> 
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #194: 
> new file mode 100644
> 
> Yup, the checkpatch stamp of approval. My screen has stopped being 
> limited to 80 chars at some point between 1989 and 1991. As for the
> MAINTAINERS file, that's probably for the maintainers to pick it up.
> 
>> Reviewed-by: Phil Elwell <phil@...pberrypi.org>
>> Tested-by: Phil Elwell <phil@...pberrypi.org>
> 
> Thanks. I assume you'll respin your DSB/SEV fix on top of this?

Yes - how does one manage the timing of interdependent patches?

Phil