linux-kernel - Re: [PATCH] staging: typec: Fix sparse warnings about incorrect types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABXOdTdwsCLOsnUX6SzwXWKK2jX-FQZE_j3h4MBJOA75xog3Rw@mail.gmail.com>
Date:   Wed, 10 May 2017 12:17:59 -0700
From:   Guenter Roeck <groeck@...gle.com>
To:     Guru Das S <gurooodas@...il.com>
Cc:     Yueyao Zhu <yueyao@...gle.com>,
        Guenter Roeck <groeck@...omium.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: typec: Fix sparse warnings about incorrect types

On Wed, May 10, 2017 at 10:15 AM, Guru Das S <gurooodas@...il.com> wrote:
> On 10 May 2017 at 08:23, Guenter Roeck <groeck@...gle.com> wrote:
>
>> Please the patch into two parts, one per file; the required changes
>> for endianness support in tcpci.c are much more complex.
>
> I will send out a patch for the two simple fixes - the use of
> pd_header_cnt_le().
>
>> Excellent catch, but the fix is wrong. We don't want to change the
>> endianness here, since the data is sent to the chip. This will require
>> a (much) more comprehensive fix - header should probably be le16, the
>> second parameter to tcpci_write16() needs to be le16, plus everything
>> that comes with it (currently the code is just not endianness clean).
>> tcpci_read16() is also incorrect and has the same problem (it is
>> really a bad idea to read 16 bit into an unsigned int pointer).
>>
>> Let me know if you want to try to fix this; otherwise I'll do it.
>
> Sure, I'd like to give this a try. I will take a closer look at the
> code and get back to you with questions.

Thanks!
Guenter