linux-kernel - Re: [PATCH] staging: greybus: power_supply: replace kzalloc by kcalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170511212317.GC2085@arch-late.localdomain>
Date:   Thu, 11 May 2017 22:23:17 +0100
From:   Rui Miguel Silva <rmfrfs@...il.com>
To:     JB Van Puyvelde <jbvanpuyvelde@...il.com>
Cc:     johan@...nel.org, elder@...nel.org, gregkh@...uxfoundation.org,
        greybus-dev@...ts.linaro.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: greybus: power_supply: replace kzalloc by
 kcalloc

Hi JB,
Great! thanks for the patch,
On Thu, May 11, 2017 at 10:58:56PM +0200, JB Van Puyvelde wrote:
>According to checkpatch.pl, kcalloc should be preferred to kzalloc with
>multiply.
>
>Signed-off-by: JB Van Puyvelde <jbvanpuyvelde@...il.com>
Reviewed-by: Rui Miguel Silva <rmfrfs@...il.com>

Cheers,
   Rui

>---
> drivers/staging/greybus/power_supply.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/staging/greybus/power_supply.c b/drivers/staging/greybus/power_supply.c
>index e85c988b7034..20cac20518d7 100644
>--- a/drivers/staging/greybus/power_supply.c
>+++ b/drivers/staging/greybus/power_supply.c
>@@ -944,7 +944,7 @@ static int gb_power_supplies_setup(struct gb_power_supplies *supplies)
> 	if (ret < 0)
> 		goto out;
>
>-	supplies->supply = kzalloc(supplies->supplies_count *
>+	supplies->supply = kcalloc(supplies->supplies_count,
> 				     sizeof(struct gb_power_supply),
> 				     GFP_KERNEL);
>
>-- 
>2.11.0
>