| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20170512053907.GS17481@vireshk-i7>
Date: Fri, 12 May 2017 11:09:07 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: JB Van Puyvelde <jbvanpuyvelde@...il.com>
Cc: rmfrfs@...il.com, devel@...verdev.osuosl.org, elder@...nel.org,
johan@...nel.org, linux-kernel@...r.kernel.org,
greybus-dev@...ts.linaro.org
Subject: Re: [greybus-dev] [PATCH] staging: greybus: power_supply: replace
kzalloc by kcalloc
On 11-05-17, 22:58, JB Van Puyvelde wrote:
> According to checkpatch.pl, kcalloc should be preferred to kzalloc with
> multiply.
>
> Signed-off-by: JB Van Puyvelde <jbvanpuyvelde@...il.com>
> ---
> drivers/staging/greybus/power_supply.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
You should have kept my Ack in this patch, as I have already given it earlier.
Anyway, here it is again.
Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
>
> diff --git a/drivers/staging/greybus/power_supply.c b/drivers/staging/greybus/power_supply.c
> index e85c988b7034..20cac20518d7 100644
> --- a/drivers/staging/greybus/power_supply.c
> +++ b/drivers/staging/greybus/power_supply.c
> @@ -944,7 +944,7 @@ static int gb_power_supplies_setup(struct gb_power_supplies *supplies)
> if (ret < 0)
> goto out;
>
> - supplies->supply = kzalloc(supplies->supplies_count *
> + supplies->supply = kcalloc(supplies->supplies_count,
> sizeof(struct gb_power_supply),
> GFP_KERNEL);
>
> --
> 2.11.0
>
> _______________________________________________
> greybus-dev mailing list
> greybus-dev@...ts.linaro.org
> https://lists.linaro.org/mailman/listinfo/greybus-dev
--
viresh
Powered by blists - more mailing lists