lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 12 May 2017 08:10:11 +0800 From: Leo Yan <leo.yan@...aro.org> To: Mathieu Poirier <mathieu.poirier@...aro.org> Cc: Jonathan Corbet <corbet@....net>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, Wei Xu <xuwei5@...ilicon.com>, Catalin Marinas <catalin.marinas@....com>, Will Deacon <will.deacon@....com>, Andy Gross <andy.gross@...aro.org>, David Brown <david.brown@...aro.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Suzuki K Poulose <suzuki.poulose@....com>, Stephen Boyd <sboyd@...eaurora.org>, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org, Mike Leach <mike.leach@...aro.org>, Sudeep Holla <sudeep.holla@....com> Subject: Re: [PATCH v9 7/9] coresight: add support for CPU debug module On Thu, May 11, 2017 at 11:12:32AM -0600, Mathieu Poirier wrote: [...] > > +static int debug_probe(struct amba_device *adev, const struct amba_id *id) > > +{ > > + void __iomem *base; > > + struct device *dev = &adev->dev; > > + struct debug_drvdata *drvdata; > > + struct resource *res = &adev->res; > > + struct device_node *np = adev->dev.of_node; > > + int ret; > > + > > + drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL); > > + if (!drvdata) > > + return -ENOMEM; > > + > > + drvdata->cpu = np ? of_coresight_get_cpu(np) : 0; > > + if (per_cpu(debug_drvdata, drvdata->cpu)) { > > + dev_err(dev, "CPU%d drvdata has been initialized, " > > s/"has been"/"has already been" > > That way it really look like an error message. Will fix. > Also debug_probe() uses dev_xyz() but everywhere else in the driver it is > pr_xyz() - any specific reason for that? I suggest moving to dev_xyz(). Some logs are shared for all device instances, so I think should use pr_xyz(); will spin a new version to change other places to use dev_xyz() if the logs are for specific device instance. > Otherwise things look good. [...] Thanks, Leo Yan
Powered by blists - more mailing lists