linux-kernel - [tip:irq/urgent] irqchip/mbigen: Fix potential NULL dereferencing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-ad7cc3c0c57d77b442db323056354d0e49833569@git.kernel.org>
Date:   Fri, 12 May 2017 01:35:07 -0700
From:   tip-bot for Hanjun Guo <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     weiyongjun1@...wei.com, wangkefeng.wang@...wei.com,
        linux-kernel@...r.kernel.org, majun258@...wei.com, hpa@...or.com,
        hanjun.guo@...aro.org, mingo@...nel.org, marc.zyngier@....com,
        tglx@...utronix.de
Subject: [tip:irq/urgent] irqchip/mbigen: Fix potential NULL dereferencing

Commit-ID:  ad7cc3c0c57d77b442db323056354d0e49833569
Gitweb:     http://git.kernel.org/tip/ad7cc3c0c57d77b442db323056354d0e49833569
Author:     Hanjun Guo <hanjun.guo@...aro.org>
AuthorDate: Fri, 12 May 2017 11:55:27 +0800
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Fri, 12 May 2017 10:25:37 +0200

irqchip/mbigen: Fix potential NULL dereferencing

platform_get_resource() may return NULL, add proper
check to avoid potential NULL dereferencing.

Signed-off-by: Hanjun Guo <hanjun.guo@...aro.org>
Acked-by: Marc Zyngier <marc.zyngier@....com>
Cc: Kefeng Wang <wangkefeng.wang@...wei.com>
Cc: linuxarm@...wei.com
Cc: Wei Yongjun <weiyongjun1@...wei.com>
Cc: MaJun <majun258@...wei.com>
Link: http://lkml.kernel.org/r/1494561328-39514-3-git-send-email-guohanjun@huawei.com
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>

---
 drivers/irqchip/irq-mbigen.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c
index 0f5e66e..2fa1e45 100644
--- a/drivers/irqchip/irq-mbigen.c
+++ b/drivers/irqchip/irq-mbigen.c
@@ -337,6 +337,9 @@ static int mbigen_device_probe(struct platform_device *pdev)
 	mgn_chip->pdev = pdev;
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+	if (!res)
+		return -EINVAL;
+
 	mgn_chip->base = devm_ioremap(&pdev->dev, res->start,
 				      resource_size(res));
 	if (!mgn_chip->base) {