linux-kernel - [tip:irq/urgent] irqchip/mbigen: Fix the clear register offset calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-9459a04b6a5a09967eec94a1b66f0a74312819d9@git.kernel.org>
Date:   Fri, 12 May 2017 01:35:38 -0700
From:   tip-bot for MaJun <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     hanjun.guo@...aro.org, weiyongjun1@...wei.com, majun258@...wei.com,
        hpa@...or.com, tglx@...utronix.de, wangkefeng.wang@...wei.com,
        mingo@...nel.org, linux-kernel@...r.kernel.org,
        marc.zyngier@....com
Subject: [tip:irq/urgent] irqchip/mbigen: Fix the clear register offset
 calculation

Commit-ID:  9459a04b6a5a09967eec94a1b66f0a74312819d9
Gitweb:     http://git.kernel.org/tip/9459a04b6a5a09967eec94a1b66f0a74312819d9
Author:     MaJun <majun258@...wei.com>
AuthorDate: Fri, 12 May 2017 11:55:28 +0800
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Fri, 12 May 2017 10:25:38 +0200

irqchip/mbigen: Fix the clear register offset calculation

The register array offset for clearing an interrupt is calculated by:

    offset = (hwirq - RESERVED_IRQ_PER_MBIGEN_CHIP) / 32;

This is wrong because the clear register array includes the reserved
interrupts. So the clear operation ends up in the wrong register.

This went unnoticed so far, because the hardware clears the real bit
through a timeout mechanism when the hardware is configured in debug
mode. That debug mode was enabled on early generations of the hardware, so
the problem was papered over.

On newer hardware with updated firmware the debug mode was disabled, so the
bits did not get cleared which causes the system to malfunction.

Remove the subtraction of RESERVED_IRQ_PER_MBIGEN_CHIP, so the correct
register is accessed.

[ tglx: Rewrote changelog ]

Fixes: a6c2f87b8820 ("irqchip/mbigen: Implement the mbigen irq chip operation functions")
Signed-off-by: MaJun <majun258@...wei.com>
Signed-off-by: Hanjun Guo <hanjun.guo@...aro.org>
Acked-by: Marc Zyngier <marc.zyngier@....com>
Cc: Kefeng Wang <wangkefeng.wang@...wei.com>
Cc: linuxarm@...wei.com
Cc: Wei Yongjun <weiyongjun1@...wei.com>
Link: http://lkml.kernel.org/r/1494561328-39514-4-git-send-email-guohanjun@huawei.com
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>

---
 drivers/irqchip/irq-mbigen.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c
index 2fa1e45..31d6b5a 100644
--- a/drivers/irqchip/irq-mbigen.c
+++ b/drivers/irqchip/irq-mbigen.c
@@ -106,10 +106,7 @@ static inline void get_mbigen_type_reg(irq_hw_number_t hwirq,
 static inline void get_mbigen_clear_reg(irq_hw_number_t hwirq,
 					u32 *mask, u32 *addr)
 {
-	unsigned int ofst;
-
-	hwirq -= RESERVED_IRQ_PER_MBIGEN_CHIP;
-	ofst = hwirq / 32 * 4;
+	unsigned int ofst = (hwirq / 32) * 4;
 
 	*mask = 1 << (hwirq % 32);
 	*addr = ofst + REG_MBIGEN_CLEAR_OFFSET;