linux-kernel - Re: [PATCH 4/4] staging: rtl8723bs: checkpatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170512093008.GA19482@kroah.com>
Date:   Fri, 12 May 2017 11:30:08 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Matthew Giassa <matthew@...ssa.net>
Cc:     hdegoede@...hat.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] staging: rtl8723bs: checkpatch - resolve indentation
 and line width

On Thu, May 11, 2017 at 06:45:24PM -0700, Matthew Giassa wrote:
> +#define	REG_INT_MIG_8723B		0x0304	/* Interrupt Migration */
> +#define	REG_BCNQ_DESA_8723B		0x0308	/* TX Beacon Descriptor Address
> +						 */
> +#define	REG_HQ_DESA_8723B		0x0310	/* TX High Queue Descriptor
> +						 * Address
> +						 */

Ick, that looks worse to me now, doesn't it to you?  Please leave the
original as-is.

Also, always test-build your patches :)

thanks,

greg k-h