linux-kernel - Re: [PATCH 4/4] staging: rtl8723bs: checkpatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 12 May 2017 05:57:44 -0700
From:   Matthew Giassa <matthew@...ssa.net>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     hdegoede@...hat.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] staging: rtl8723bs: checkpatch - resolve indentation
 and line width

* Greg KH <gregkh@...uxfoundation.org> [2017-05-12 11:30:08 +0200]:

>On Thu, May 11, 2017 at 06:45:24PM -0700, Matthew Giassa wrote:
>> +#define	REG_INT_MIG_8723B		0x0304	/* Interrupt Migration */
>> +#define	REG_BCNQ_DESA_8723B		0x0308	/* TX Beacon Descriptor Address
>> +						 */
>> +#define	REG_HQ_DESA_8723B		0x0310	/* TX High Queue Descriptor
>> +						 * Address
>> +						 */
>
>Ick, that looks worse to me now, doesn't it to you?  Please leave the
>original as-is.

Will do.

>Also, always test-build your patches :)


Strange. That built fine on my Ubuntu x64 system:

&> make -j2 drivers/staging/rtl8723bs/

...

  CC      arch/x86/kernel/asm-offsets.s
  GEN     scripts/gdb/linux/constants.py
  CHK     include/generated/asm-offsets.h
  UPD     include/generated/asm-offsets.h
  CALL    scripts/checksyscalls.sh
  LD      drivers/staging/rtl8723bs/built-in.o

$> gcc --version
gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609

>thanks,
>
>greg k-h

Cheers!

-- 

Matthew