linux-kernel - Re: [PATCH 4.4 42/60] scsi: scsi_dh_emc: return success in clariion_std

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170512131210.GB13103@kroah.com>
Date:   Fri, 12 May 2017 15:12:10 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Ben Hutchings <ben.hutchings@...ethink.co.uk>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Hannes Reinecke <hare@...e.de>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH 4.4 42/60] scsi: scsi_dh_emc: return success in
 clariion_std_inquiry()

On Fri, May 12, 2017 at 12:36:13PM +0100, Ben Hutchings wrote:
> On Thu, 2017-05-11 at 16:13 +0200, Greg Kroah-Hartman wrote:
> > 4.4-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Dan Carpenter <dan.carpenter@...cle.com>
> > 
> > commit 4d7d39a18b8b81511f0b893b7d2203790bf8a58b upstream.
> > 
> > We accidentally return an uninitialized variable on success.
> 
> No we don't.
> 
> > Fixes: b6ff1b14cdf4 ("[SCSI] scsi_dh: Update EMC handler")
> 
> Actually fixes: b78205c93297 ("scsi_dh_emc: switch to
> scsi_execute_req_flags()") so this is only needed for 4.11.y.

Ah, thanks for catching this, removed now from all of the queues.

greg k-h