lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 12 May 2017 09:16:04 -0400 From: Tejun Heo <tj@...nel.org> To: Vincent Guittot <vincent.guittot@...aro.org> Cc: Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>, linux-kernel <linux-kernel@...r.kernel.org>, Linus Torvalds <torvalds@...ux-foundation.org>, Mike Galbraith <efault@....de>, Paul Turner <pjt@...gle.com>, Chris Mason <clm@...com>, kernel-team@...com Subject: Re: [PATCH v2 for-4.12-fixes 2/2] sched/fair: Fix O(# total cgroups) in load balance path Hello, Vincent. On Thu, May 11, 2017 at 09:02:22AM +0200, Vincent Guittot wrote: > Sorry, what i mean is: > When the group entity of a cfs_rq is enqueued, we are sure that either > the parents is already enqueued or it will be enqueued in the same > sequence. We must be sure that no other branch will be enqueued in the > middle of the sequence and will reset tmp_alone_branch. > This is true with current implementation but I wondered it can happen > if we del/add the cfs_rq out of order > > That said i haven't find a use case that break the sequence Hmm... a cfs_rq can be removed from leaf list iff it's empty and dequeued, and enqueueing is always from top down. If an ancestor is already enqueued, it's guaranteed to be on the leaf list; otherwise, it's guaranteed to be enqueued beforehand and thus put on the leaf list too. I think it should be fine. Thanks. -- tejun
Powered by blists - more mailing lists