linux-kernel - Re: [PATCH] ASoC: max98927: Adding support for TDM mode and Envelop tracking control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170514101115.f53hlcbp7z4muelu@sirena.org.uk>
Date:   Sun, 14 May 2017 19:11:15 +0900
From:   Mark Brown <broonie@...nel.org>
To:     Ryan Lee <ryans.lee@...imintegrated.com>
Cc:     lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        ryan.lee.maxim@...il.com
Subject: Re: [PATCH] ASoC: max98927: Adding support for TDM mode and Envelop
 tracking control

On Fri, May 05, 2017 at 10:42:15AM -0700, Ryan Lee wrote:
> Signed-off-by: Ryan Lee <ryans.lee@...imintegrated.com>
> ---

The subject line suggests that this is adding two new features.  Unless
they are very closely related in the code they should be submitted as
separate patches as covered in SubmittingPatches.

>  	default:
> -		dev_err(codec->dev, "DAI clock mode unsupported");
> +		dev_err(codec->dev, "DAI clock mode unsupported\n");
>  		return -EINVAL;
>  	}
>  

It also seems like there are a number of unrelated stylistic changes in
this patch.  While it's fine to make such changes they too should be in
separate patches.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)