linux-kernel - Re: [PATCH] ASoC: max98927: Adding support for TDM mode and Envelop tracking control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAN4-oj=_M+vBOXF7rmgUXD3eA282FEj_rQn-3OqL3hpe0nRVVg@mail.gmail.com>
Date:   Thu, 18 May 2017 20:12:26 -0700
From:   Ryan Lee <ryans.lee@...imintegrated.com>
To:     Mark Brown <broonie@...nel.org>
CC:     Liam Girdwood <lgirdwood@...il.com>, <perex@...ex.cz>,
        <tiwai@...e.com>, <alsa-devel@...a-project.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: max98927: Adding support for TDM mode and Envelop
 tracking control

On Sun, May 14, 2017 at 3:11 AM, Mark Brown <broonie@...nel.org> wrote:
> On Fri, May 05, 2017 at 10:42:15AM -0700, Ryan Lee wrote:
>> Signed-off-by: Ryan Lee <ryans.lee@...imintegrated.com>
>> ---
>
> The subject line suggests that this is adding two new features.  Unless
> they are very closely related in the code they should be submitted as
> separate patches as covered in SubmittingPatches.

Thank you for your feedback.
I separated this patch to five separate patches.

>
>>       default:
>> -             dev_err(codec->dev, "DAI clock mode unsupported");
>> +             dev_err(codec->dev, "DAI clock mode unsupported\n");
>>               return -EINVAL;
>>       }
>>
>
> It also seems like there are a number of unrelated stylistic changes in
> this patch.  While it's fine to make such changes they too should be in
> separate patches.

I applied this to separate patch.