linux-kernel - Re: [PATCH 6/9] regulator: palmas: Drop unnecessary static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1705151838370.4315@hadrien>
Date:   Mon, 15 May 2017 18:41:41 +0800 (SGT)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Mark Brown <broonie@...nel.org>
cc:     Tony Lindgren <tony@...mide.com>, keescook@...omium.org,
        kernel-janitors@...r.kernel.org,
        Liam Girdwood <lgirdwood@...il.com>,
        linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/9] regulator: palmas: Drop unnecessary static

On Sun, 14 May 2017, Mark Brown wrote:

> On Thu, May 04, 2017 at 10:10:51PM +0200, Julia Lawall wrote:
> > Drop static on a local variable, when the variable is initialized before
> > any use, on every possible execution path through the function.
>
> When sending a bunch of changes like this please either send the cover
> letter to everyone or send each patch separately (this seems like it
> stands alone just fine).  The first question when only one patch in a
> series is visible is always what are the interdependencies.

Not sure what is best to do.  If the cover letter goes to everyone, it
could be rejected for too many recipients.  Currently it goes to all the
mailing lists.  If the patches are sent separately, then could there be a
cover letter for each one?  If the semantic patch is complicated, then I
typically put the whole thing there, and an abbreviated one in the actual
patch.  That is not relevant here, because the semantic patch is small.
Part of the purpose of the cover letter was to allow people who were not
interested to skip over the whole thing at once.

julia