linux-kernel - Re: [patch 11/18] iommu/of: Adjust system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f8410f3-fa70-d205-003b-168c0c229053@arm.com>
Date:   Mon, 15 May 2017 11:45:51 +0100
From:   Robin Murphy <robin.murphy@....com>
To:     Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     Mark Rutland <mark.rutland@....com>,
        Peter Zijlstra <peterz@...radead.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        iommu@...ts.linux-foundation.org, Ingo Molnar <mingo@...nel.org>
Subject: Re: [patch 11/18] iommu/of: Adjust system_state check

On 14/05/17 19:27, Thomas Gleixner wrote:
> To enable smp_processor_id() and might_sleep() debug checks earlier, it's
> required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING.
> 
> Adjust the system_state check in of_iommu_driver_present() to handle the
> extra states.

FWIW,

Acked-by: Robin Murphy <robin.murphy@....com>

> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: Joerg Roedel <joro@...tes.org>
> Cc: iommu@...ts.linux-foundation.org
> ---
>  drivers/iommu/of_iommu.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/iommu/of_iommu.c
> +++ b/drivers/iommu/of_iommu.c
> @@ -103,7 +103,7 @@ static bool of_iommu_driver_present(stru
>  	 * it never will be. We don't want to defer indefinitely, nor attempt
>  	 * to dereference __iommu_of_table after it's been freed.
>  	 */
> -	if (system_state > SYSTEM_BOOTING)
> +	if (system_state >= SYSTEM_RUNNING)
>  		return false;
>  
>  	return of_match_node(&__iommu_of_table, np);
>