linux-kernel - Re: [patch v2 1/1] staging: speakup: flush tty buffers and ensure hardware flow control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170515104556.GA32112@kroah.com>
Date:   Mon, 15 May 2017 12:45:56 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Okash Khawaja <okash.khawaja@...il.com>
Cc:     Samuel Thibault <samuel.thibault@...-lyon.org>,
        Alan Cox <gnomes@...rguk.ukuu.org.uk>,
        linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
        Kirk Reiser <kirk@...sers.ca>, speakup@...ux-speakup.org,
        John Covici <covici@....covici.com>,
        Chris Brannon <chris@...-brannons.com>
Subject: Re: [patch v2 1/1] staging: speakup: flush tty buffers and ensure
 hardware flow control

On Fri, May 12, 2017 at 08:43:58PM +0100, Okash Khawaja wrote:
> This patch fixes the issue where TTY-migrated synths would take a while
> to shut up after hitting numpad enter key. When calling synth_flush,
> even though XOFF character is sent as high priority, data buffered in
> TTY layer is still sent to the synth. This patch flushes that buffered
> data when synth_flush is called.
> 
> It also tries to ensure that hardware flow control is enabled, by
> setting CRTSCTS using tty's termios.
> 
> Reported-by: John Covici <covici@....covici.com>
> Signed-off-by: Okash Khawaja <okash.khawaja@...il.com>
> Reviewed-by: Samuel Thibault <samuel.thibault@...-lyon.org>

Doesn't apply as I didn't take your full series.  Please resend it with
that series fixed up.

thanks,

greg k-h