linux-kernel - Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 15 May 2017 11:53:19 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Vignesh R <vigneshr@...com>, linux-spi <linux-spi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA

On Mon, May 15, 2017 at 12:21:33PM +0200, Geert Uytterhoeven wrote:
> On Mon, May 15, 2017 at 12:12 PM, Mark Brown <broonie@...nel.org> wrote:

> > No, I was thinking more just not needing the dependency at all.

> Then what's the point of the existence of COMPILE_TEST?
> We can just have stubs for everything, and always build everything.

It's useful for platform specific devices (like this one should be) but
having to add dependencies for basic kernel APIs like the DMA one is
just making for a lot of noise.  There's plenty of platforms without DMA
that also have no real use for this driver, it's not really a relevant
thing when deciding if the driver might be useful if what you're trying
to do is hide drivers that aren't useful on the platform.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)