linux-kernel - Re: [PATCH v11 4/5] LRNG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1705151852591.4315@hadrien>
Date:   Mon, 15 May 2017 18:54:38 +0800 (SGT)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Stephan Müller <smueller@...onox.de>
cc:     linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        "Jason A. Donenfeld" <Jason@...c4.com>, kbuild-all@...org
Subject: Re: [PATCH v11 4/5] LRNG - enable compile (fwd)

Hello,

I received the following report from kbuild about some coccinelle detected
errors.  I wasn't sure what to look at at the URL to check them.  I
already forwarded the patch for the last case.

julia

---------- Forwarded message ----------
Date: Mon, 15 May 2017 14:09:39 +0800
From: kbuild test robot <fengguang.wu@...el.com>
To: kbuild@...org
Cc: Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH v11 4/5] LRNG - enable compile

CC: kbuild-all@...org
In-Reply-To: <2619717.M11260EEPi@...itron.chronox.de>
TO: "Stephan Müller" <smueller@...onox.de>
CC: linux-kernel@...r.kernel.org
CC: linux-crypto@...r.kernel.org, "Jason A. Donenfeld" <Jason@...c4.com>

Hi Stephan,

[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on v4.12-rc1 next-20170512]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Stephan-M-ller/dev-random-a-new-approach/20170514-223633
:::::: branch date: 16 hours ago
:::::: commit date: 16 hours ago

>> drivers/char/lrng_base.c:2243:5-25: duplicated argument to && or ||
--
>> drivers/char/lrng_base.c:1245:7-11: ERROR: iterator variable bound on line 1236 cannot be NULL
--
>> drivers/char/lrng_base.c:1509:19-24: ERROR: reference preceded by free on line 1453
--
>> drivers/char/lrng_base.c:1461:1-11: alloc with no test, possible model on line 1466
--
>> drivers/char/lrng_base.c:1526:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation