linux-kernel - Re: [PATCH] Use device_property_read instead of of_property_read in the dw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdqV35EDUo3m19_9M7cYzvZnsJ7Ou1+ks9_S-8qDhDLZQ@mail.gmail.com>
Date:   Mon, 15 May 2017 16:30:08 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Ulf Hansson <ulf.hansson@...aro.org>
Cc:     David Woods <dwoods@...lanox.com>,
        Jaehoon Chung <jh80.chung@...sung.com>,
        Shawn Lin <shawn.lin@...k-chips.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Adrian Hunter <adrian.hunter@...el.com>, cmetcalf@...lanox.com,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Use device_property_read instead of of_property_read in
 the dw_mmc driver

On Mon, May 15, 2017 at 12:36 PM, Ulf Hansson <ulf.hansson@...aro.org> wrote:
> On 25 April 2017 at 17:39, David Woods <dwoods@...lanox.com> wrote:
>> Using the device_property interfaces allows the dw_mmc driver to work
>> on platforms which run on either device tree or ACPI.

> Can you please split this to two separate changes. One for dw_mmc with
> a proper prefix (mmc: dw_mmc:) and one for the mmc core (prefix "mmc:
> core:").

Btw, for the core part of change I would recommend to check other API
functions which might go slightly different in case of ACPI vs DT vs
built-in device properties.

For example, if any code is using of_gpio header and of_ related stuff
it should be rethought as well (not sure if we would change there
anything, though worth to double check).

-- 
With Best Regards,
Andy Shevchenko