linux-kernel - Re: [patch 04/18] x86/smp: Adjust system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170515101708.18607054@gandalf.local.home>
Date:   Mon, 15 May 2017 10:17:08 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [patch 04/18] x86/smp: Adjust system_state check

On Sun, 14 May 2017 20:27:20 +0200
Thomas Gleixner <tglx@...utronix.de> wrote:

> To enable smp_processor_id() and might_sleep() debug checks earlier, it's
> required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING.
> 
> Adjust the system_state check in announce_cpu() to handle the extra states.
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>

Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve

> ---
>  arch/x86/kernel/smpboot.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/arch/x86/kernel/smpboot.c
> +++ b/arch/x86/kernel/smpboot.c
> @@ -863,7 +863,7 @@ static void announce_cpu(int cpu, int ap
>  	if (cpu == 1)
>  		printk(KERN_INFO "x86: Booting SMP configuration:\n");
>  
> -	if (system_state == SYSTEM_BOOTING) {
> +	if (system_state < SYSTEM_RUNNING) {
>  		if (node != current_node) {
>  			if (current_node > (-1))
>  				pr_cont("\n");
>