lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 15 May 2017 16:18:49 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Yury Norov <ynorov@...iumnetworks.com>
Cc:     linux-arch <linux-arch@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Richard Henderson <rth@...ddle.net>,
        Ivan Kokshaysky <ink@...assic.park.msu.ru>,
        Matt Turner <mattst88@...il.com>,
        Akinobu Mita <mita@...aclelinux.com>,
        Mike Galbraith <efault@....de>
Subject: Re: [PATCH] sched: remove sched_find_first_bit()

On Sat, May 13, 2017 at 3:01 AM, Yury Norov <ynorov@...iumnetworks.com> wrote:

> include/asm-generic/bitops/sched.h as it declares only this
> function.  Alpha has it's own implementation, very similar to
> generic one, so it is also removed.

Nice consolidation, I see that every architecture once had a copy of
this function, and they were all removed at one point long ago,
except for Alpha, and there is no reason to leave that one in the tree.

I'll leave it to you and Ingo to figure out what the two callers should
do, but for removing function from asm-generic:

Acked-by: Arnd Bergmann <arnd@...db.de>

Maybe you could split the patch into two changesets, and make the
first of them move the function to kernel/sched/rt.c, and the second
one (if we still want it then) can change the implementation to whatever
you conclude is ideal.

      Arnd

Powered by blists - more mailing lists