linux-kernel - Re: [PATCH v3] drivers/staging: refactor dgnc tty registration.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170516075120.sponc2rkyoxfz5mn@mwanda>
Date:   Tue, 16 May 2017 10:51:21 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Haim Daniel <haimdaniel@...il.com>
Cc:     devel@...verdev.osuosl.org, lidza.louina@...il.com,
        driverdev-devel@...uxdriverproject.org,
        linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org
Subject: Re: [PATCH v3] drivers/staging: refactor dgnc tty registration.

On Mon, May 15, 2017 at 04:49:16PM +0300, Haim Daniel wrote:
> me@...m-toshiba1 ~ $ dpkg -l sparse
> Desired=Unknown/Install/Remove/Purge/Hold
> |
> Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
> |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
> ||/ Name              Version       Architecture  Description
> +++-=================-=============-=============-========================================
> ii  sparse            0.4.5~rc1-1   amd64         semantic parser of source
> files
> 
> me@...m-toshiba1 linux (next-20170512) $ make clean M=drivers/staging
> /dgnc/; make C=1 M=drivers/staging/dgnc/
> 
> drivers/staging/dgnc/dgnc_tty.c:66:25: warning: too long initializer-string
> for array of char
> 

I downloaded the latest Sparse and don't see that warning.  But GCC has
a warning like that so I think this is really a GCC warning.  It doesn't
trigger for me, and with my config it's in fact, not a bug.  The buffer
is 19 characters and INIT_C_CC is 17 chars plus 1 NUL terminator.

All these things are generic termios defines so I'm not even sure how
you're triggering the warning.

Anyway, your patch is harmless enough.

regards,
dan carpenter