linux-kernel - Re: [PATCH v4] drivers/staging: refactor dgnc tty registration.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170516075421.cjqaw67nnmwithjx@mwanda>
Date:   Tue, 16 May 2017 10:54:21 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Haim Daniel <haimdaniel@...il.com>
Cc:     lidza.louina@...il.com, markh@...pro.net,
        gregkh@...uxfoundation.org, driverdev-devel@...uxdriverproject.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] drivers/staging: refactor dgnc tty registration.

On Mon, May 15, 2017 at 05:10:18PM +0300, Haim Daniel wrote:
> -remove duplicate tty allocation code for serial and printer drivers.
> -add missing tty c_ispeed and c_ospeed initialization to 9600.
> -fix sparse warning: too long initializer-string for array of char.

This is a GCC warning and not a Sparse warning.  I still have no idea
how it's getting triggered.  But otherwise I have reviewed the patch and
it's a nice clean up.

regards,
dan carpenter