linux-kernel - Re: [PATCH] nvmem: core: Prevent memory leak when device is unregistered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHQ1cqE-+-_96tmAONkfM4+Rx5K=ODOD9NuWOZsPE=suvDUGBg@mail.gmail.com>
Date:   Tue, 16 May 2017 14:33:55 -0700
From:   Andrey Smirnov <andrew.smirnov@...il.com>
To:     Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nvmem: core: Prevent memory leak when device is unregistered

On Mon, May 15, 2017 at 4:13 AM, Mika Westerberg
<mika.westerberg@...ux.intel.com> wrote:
> The nvmem_unregister() calls device_del() for the device but forgets to
> call put_device() to actually release the device object which causes
> that memory to be leaked.
>
> Fix this by calling device_unregister() for the device intead which also
> calls put_device() for the device releasing it eventually.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> ---

FWIW, I submitted similar fix for this here:

lkml.kernel.org/r/20170418142454.23921-2-andrew.smirnov@...il.com

>  drivers/nvmem/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> index 8c830a80a648..112c8072e0f3 100644
> --- a/drivers/nvmem/core.c
> +++ b/drivers/nvmem/core.c
> @@ -528,7 +528,7 @@ int nvmem_unregister(struct nvmem_device *nvmem)
>                 device_remove_bin_file(nvmem->base_dev, &nvmem->eeprom);
>
>         nvmem_device_remove_all_cells(nvmem);
> -       device_del(&nvmem->dev);
> +       device_unregister(&nvmem->dev);
>
>         return 0;
>  }
> --
> 2.11.0
>