linux-kernel - Re: [PATCH] nvmem: core: Prevent memory leak when device is unregistered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170517091028.GB11602@lahna.fi.intel.com>
Date:   Wed, 17 May 2017 12:10:28 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Andrey Smirnov <andrew.smirnov@...il.com>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nvmem: core: Prevent memory leak when device is
 unregistered

On Tue, May 16, 2017 at 02:33:55PM -0700, Andrey Smirnov wrote:
> On Mon, May 15, 2017 at 4:13 AM, Mika Westerberg
> <mika.westerberg@...ux.intel.com> wrote:
> > The nvmem_unregister() calls device_del() for the device but forgets to
> > call put_device() to actually release the device object which causes
> > that memory to be leaked.
> >
> > Fix this by calling device_unregister() for the device intead which also
> > calls put_device() for the device releasing it eventually.
> >
> > Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> > ---
> 
> FWIW, I submitted similar fix for this here:
> 
> lkml.kernel.org/r/20170418142454.23921-2-andrew.smirnov@...il.com

Cool, let's go with that one instead then :)