linux-kernel - [PATCH -next] dma: bcm-sba-raid: fix build errors and dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <e21b438b-ab97-ad1a-7108-a2b3d28283ff@infradead.org>
Date:   Wed, 17 May 2017 09:40:47 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     LKML <linux-kernel@...r.kernel.org>,
        Anup Patel <anup.patel@...adcom.com>,
        Vinod Koul <vinod.koul@...el.com>
Cc:     "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>
Subject: [PATCH -next] dma: bcm-sba-raid: fix build errors and dependencies

From: Randy Dunlap <rdunlap@...radead.org>

Fix build errors when COMPILE_TEST is enabled but RAID6_PQ is not
enabled (seen on x86_64).

drivers/built-in.o: In function `sba_prep_dma_pq_req':
(.text+0x16132): undefined reference to `raid6_gflog'
drivers/built-in.o: In function `sba_prep_dma_pq_single_req':
(.text+0x162f4): undefined reference to `raid6_gflog'

This driver needs RAID6_PQ and MAILBOX (from inspection) independent of
ARM64 or COMPILE_TEST.

However, RAID6_PQ is not defined in any Kconfig file, although it is
used in several of them. :(

Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: Anup Patel <anup.patel@...adcom.com>
Cc: Vinod Koul <vinod.koul@...el.com>
Cc: dmaengine@...r.kernel.org
---
 drivers/dma/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- linux-next-20170517.orig/drivers/dma/Kconfig
+++ linux-next-20170517/drivers/dma/Kconfig
@@ -101,7 +101,8 @@ config AXI_DMAC
 
 config BCM_SBA_RAID
 	tristate "Broadcom SBA RAID engine support"
-	depends on (ARM64 && MAILBOX && RAID6_PQ) || COMPILE_TEST
+	depends on ARM64 || COMPILE_TEST
+	depends on MAILBOX && RAID6_PQ
 	select DMA_ENGINE
 	select DMA_ENGINE_RAID
 	select ASYNC_TX_DISABLE_XOR_VAL_DMA